Adapt to chacha20 #1642
Open
Adapt to chacha20 #1642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhardy
reviewed
Jun 15, 2025
This was referenced Jun 16, 2025
|
I opened #1643. This PR is useful as a draft but won't be merged in its current form (likely we'll want the MSRV/edition bump first as its own PR). I'm not certain on the timeline yet; the main blocker is the |
tarcieri
reviewed
Aug 11, 2025
This was referenced Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
Replaced the dependency on
rand_chachawith one onchacha20. Added some tests tostd.rsto ensure that the output ofStdRngdid not change.Fixes #934.
Motivation
Reduces total code size and the total amount of unsafe code.
Details
Changes to config.toml and some replacement of
rand_chacha::withchacha20::.Added three new unit tests to std.rs. These were based on tests of IETF test vectors from
rand_chacha, but the actualexpectedvalues had to be replaced, as the IETF test vectors are for ChaCha20 whileranduses ChaCha12. Theexpectedvalues were generated by usingrand_chacha(beforechacha20was used) to verify that the algorithm change did not affect the output.